source-academy / frontend / 29626747677

42%

Build Type

push

github

Committed by web-flow

Commit Message

Add Dynamic Tab and Plugin Loading (#3977)

* feat: add tab manager

* feat: load external plugins from plugin directory

* feat: add react konva and konva to require provider

* feat: provide konva and react-konva via require provider

* feat: add module loader

* feat: add new module feature flag

* feat: add module to public flags

* feat: add module registry

* fix: remove automatic lang directory URL change

* Focus and auto-redirect dynamically-loaded module side content tabs

showTab() only added a tab to the visible list without ever focusing
it, so a module's tab (e.g. sound's) would appear in the tab bar but
never become the active view. Focus it on show, since a module
deciding to show its tab means it wants it looked at now.

Also generalize the evaluation-error tab redirect: it only reverted to
the Introduction tab for the hardcoded Stepper/CSE Machine tab ids, so
any other dynamically-registered module tab was left showing a dead
view on error. Check against sideContentManager's currently registered
tabs instead of hardcoding ids.

* Fix review comments on #3977: worker leak, unpublished dep, subscribe churn

- evalCode.ts: evalCodeConductorSaga's finally block never terminated
  the consumed conductor, despite getPreparedConductorSaga's own
  contract that the caller does so - every Run leaked its Worker
  instead of shutting it down.
- package.json: @sourceacademy/web-module-loader was pinned to a
  relative file:../plugins/src/web/module-loader path, which only
  resolves with a sibling plugins checkout next to frontend (breaks
  for anyone else, including CI). Switched to the published npm
  version (^0.0.2) - verified byte-identical to the relative path's
  current content before switching.
- SideContentManager.ts/SideContentProvider.tsx: subscribe was a plain
  method, so passing it to useSyncExternalStore needed .bind() on
  every render (a new function reference each time), causing
  unsubscribe/resubscribe on every render. Made ... (continued)

Coverage Stats

2743 of 7549 branches covered (36.34%)

Branch coverage included in aggregate %.

7 of 32 new or added lines in 9 files covered. (21.88%)

10 existing lines in 4 files now uncovered.

6443 of 14168 relevant lines covered (45.48%)

28.09 hits per line