stephenafamo / scan / 29624104139

90%

main: 91%

Pull #10

github

fix: close rows in OneFromRows, AllFromRows and CursorFromRows to prevent connection leak

OneFromRows and AllFromRows now use defer rows.Close() to ensure the
underlying rows are always released back to the pool. Previously callers
were responsible for closing, which led to connection leaks when the
caller forgot (e.g. QueryStmt.One in bob never exhausted the result set,
so database/sql could not auto-release the connection).

CursorFromRows now closes rows on its wrapRows error path; on success
the cursor takes ownership.

The higher-level convenience functions One and All previously had their
own defer rows.Close(), which is now redundant and has been removed.

3 of 4 new or added lines in 1 file covered. (75.0%)

576 of 641 relevant lines covered (89.86%)

42.38 hits per line