gimli-rs / object / 29622362149

73%

master: 57%

Build Type

push

github

Committed by web-flow

Commit Message

Fix skipping the COFF `/<ECSYMBOLS>/` member when no names table is present (#947)

The Arm64EC EC symbol table member is only skipped by `ArchiveFile::parse`
when a `//` long-names member immediately precedes it. When the archive has
no `//` member (which `llvm-ar` omits when all member names fit in the
header), the two sequential checks parse the wrong members: the `//` check
consumes `/<ECSYMBOLS>/`, and the ECSYMBOLS check consumes the first real
object. As a result `members_offset` is left pointing at `/<ECSYMBOLS>/`,
so `members()` yields it and callers (e.g. rustc) fail to parse it as an
object file.

Nest the ECSYMBOLS check inside the `//` branch and add a separate check for
the case where `/<ECSYMBOLS>/` directly follows the second linker member, so
it is skipped regardless of whether a names table is present.

Coverage Stats

52 of 52 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

19194 of 26399 relevant lines covered (72.71%)

11321.58 hits per line