ExWeb3 / elixir_ethers / f6ded29eedb6a6be947d2a295ce08ed10b453ee8-PR-264

88%

main: 88%

Pull #264

github

Address PR review: harden typed-data signing/recovery contracts

- Ethers.sign_typed_data/2: return {:error, :not_supported} instead of
  crashing with UndefinedFunctionError when the resolved signer does not
  implement the optional sign_typed_data/2 callback (scoped rescue; other
  UndefinedFunctionErrors are re-raised).
- Signer.JsonRPC.sign_typed_data/2: return {:error, :missing_from_address}
  instead of raising KeyError when :from is absent, honoring the callback's
  {:ok, _} | {:error, _} contract.
- TypedData.recover_signer/2: return {:error, :invalid_signature} on
  malformed input (bad length/hex) instead of raising, matching the
  documented return and making valid_signature?/3 robust; also accept v as
  raw parity (0/1) in addition to 27/28 for wider signer interoperability.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

226 of 243 new or added lines in 8 files covered. (93.0%)

1269 of 1438 relevant lines covered (88.25%)

41.63 hits per line