vocdoni / saas-backend / 29569019730

62%

Pull #583

github

fix(processes): serialize org address as internal.HexBytes (bare hex) (#579)

* fix(processes): serialize org address as internal.HexBytes (bare hex)

The /processes API typed orgAddress as common.Address, which JSON-marshals to a
0x-prefixed EIP-55-checksummed string — inconsistent with upstreamId (and the
other hex ids in these types), which use internal.HexBytes (bare lowercase hex).
Switch CreateVotingProcessRequest.OrgAddress and VotingProcessResponse.OrgAddress
to internal.HexBytes for a consistent API.

- Response: VotingProcessResponseFromDB converts the db common.Address via .Bytes().
- Request: createVotingProcessHandler validates len == common.AddressLength
  (HexBytes, unlike common.Address, doesn't enforce a 20-byte length on decode)
  and converts once to common.Address for the db/auth/subscription calls.
- Inputs stay compatible: HexBytes.UnmarshalJSON strips an optional 0x prefix, so
  clients may still send "0x…". Only the response format changes to bare hex.

Scope is limited to what #571 introduced; legacy /process and census types keep
common.Address.

* chore(processes): address review feedback

- reject the all-zero org address with 400 (the length-only check let it
  through to the role check, returning 401 and changing prior behavior).
- use a full 20-byte (40-hex) orgAddress swagger example instead of the
  4-byte "deadbeef" on the request and response types.
- add TestVotingProcessOrgAddressWireFormat: inspects the raw HTTP body and
  asserts orgAddress serializes as bare lowercase hex (no 0x / no checksum),
  which struct-parsing tests can't catch.

1196 of 2101 new or added lines in 24 files covered. (56.93%)

11494 of 18489 relevant lines covered (62.17%)

44.91 hits per line