decentraland / sites / 29563381742

96%

push

github

fix: resolve world base parcel for storage instead of defaulting to 0,0 (#681)

* fix: resolve world base parcel for storage instead of defaulting to 0,0

World storage requests sent no parcel when the URL carried no `position`
(direct/deep-link entry, or before the scene list loaded). The storage-service
reads an absent parcel as `0,0`, which fails for worlds deployed off-origin.

Guarantee the world's base parcel is always resolved before any request:
- useStorageScope resolves the base from getWorldScenes when a world realm has
  no explicit position (pure useMemo; URL position stays authoritative).
- StorageLayout gates content behind a loader/error and the storage pages skip
  their reads until resolved; WorldCard disables Edit until scenes load.
- createScopedSignedFetch refuses a world request with no parcel (400).
- Fix isEns regex to accept hyphens/underscores so worlds like
  common-ground.dcl.eth are detected (previously bypassed the whole path).

Also documents:
- CLAUDE.md: tsc -b typechecks *.spec files; jest.mock React.createElement convention.

* refactor: address storage PR review (isEns → utils, scope blocked flag, test fixes)

- Extract isEns to src/utils/ens.ts (shared by features/places + features/storage)
  so storage no longer deep-imports the places domain (Pre-PR Rule 4). New
  src/utils/ens.spec.ts owns the ENS tests, including hyphen/underscore cases.
- Add a derived `blocked` flag to useStorageScope so the four storage pages skip
  their reads with `!identity || blocked` instead of repeating `isResolving || unresolved`.
- Belt-and-suspenders guard now throws 422 (not 400) so it no longer maps to the
  misleading "sign out and back in" message; it should never fire anyway.
- Use jest.resetAllMocks() in the new specs (repo convention) and add the missing
  collaborator-role, position-caption, and non-ENS-realm coverage cases.

4191 of 4681 branches covered (89.53%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 6 files covered. (100.0%)

9830 of 9917 relevant lines covered (99.12%)

16.98 hits per line