archetech / archon / 29551782432

90%

main: 90%

Build Type

Pull #737

github

Committed by macterra

Commit Message

fix: honour a zero inline limit, and stop Number() coercion smuggling one in

Review catches, both valid.

`bytes > limit` inlined a 0-byte file even at limit 0, because 0 > 0 is false --
contradicting the documented "0 links everything" on the one file where nobody
would notice until they relied on it. The condition now states what may be
inlined, so a zero limit links every file.

parseInlineLimit leaned on Number(), which reads ' ' as 0, '0x10' as 16 and
'1e4' as 10000 -- all of which passed the isInteger check. The whitespace case
is the dangerous one: a stray space in an env var silently meant "link
everything", while an empty value meant the default, which is an absurd
distinction to hang on whitespace. It now trims, treats blank as unset, and
requires base-10 digits.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #737: feat: link large file assets instead of inlining base64 (#735)

Coverage Stats

2970 of 3521 branches covered (84.35%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

6168 of 6595 relevant lines covered (93.53%)

834.84 hits per line