bedrock-kv / bedrock / c6545a600a81cc2df2ef47af067210437c8046be-PR-97

76%

develop: 73%

Build Type

Pull #97

github

Committed by jallum

Commit Message

Fix three flaky test races failing develop CI (bedrock-yp2) (#111)

## Summary

Three timing-sensitive tests each failed one recent develop CI run,
always on the OTP 27.2 / Elixir 1.17.3 matrix job (the slowest). In
every failing log the product behaved correctly — the test's
synchronization lost a race. This PR fixes the test-code races with
minimal changes; no product code is touched.

- **`distributor/server_test.exs`** (run 29548302754): `Process.monitor`
is attached after the distributor starts; when the sweep delta is
rejected quickly the distributor exits before the monitor attaches, so
the `:DOWN` arrives with `:noproc` instead of `:normal`. The DOWN
assertion now accepts either; the `stopped` telemetry assertion still
verifies the exit reason was `:normal`.
- **`distributor/readoption_test.exs`** (run 29447945622):
`:sys.get_state(distributor)` raced with the distributor stopping
normally — the test's expected outcome. Dropped the `get_state` (the
placeholder-vs-adopted pid distinction is covered by the earlier
sweep/re-adoption test) and applied the same `:noproc` guard to the
DOWN.
- **`olivine/genserver_integration_test.exs`** (run 29548013855): a 1 ms
`GenServer.call` intended to "succeed or timeout gracefully" wasn't
wrapped, so a real timeout on a slow runner crashed the test. Now
caught, falling through to the existing process-survives assertion.

## Testing

- All 44 tests in the three affected files pass locally.
- `mix format --check-formatted` and `mix credo` clean on the changed
files.

Closes bedrock-yp2.

Pull Request Pull Request #97: [INTEGRATION] bedrock-q67 Phase A: shards heal their own coverage — placeholder reads, on-demand materializers, death healing, warm re-adoption, idle spin-down

Coverage Stats

755 of 833 new or added lines in 41 files covered. (90.64%)

6 existing lines in 5 files now uncovered.

6508 of 8591 relevant lines covered (75.75%)

914.66 hits per line