bedrock-kv / bedrock / 5789085b87620d5c89d81b701d098880b1748803
73%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 225
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 75.163%. Remained the same
5789085b87620d5c89d81b701d098880b1748803

push

github

web-flow 
Fix three flaky test races failing develop CI (bedrock-yp2) (#111)

## Summary

Three timing-sensitive tests each failed one recent develop CI run,
always on the OTP 27.2 / Elixir 1.17.3 matrix job (the slowest). In
every failing log the product behaved correctly — the test's
synchronization lost a race. This PR fixes the test-code races with
minimal changes; no product code is touched.

- **`distributor/server_test.exs`** (run 29548302754): `Process.monitor`
is attached after the distributor starts; when the sweep delta is
rejected quickly the distributor exits before the monitor attaches, so
the `:DOWN` arrives with `:noproc` instead of `:normal`. The DOWN
assertion now accepts either; the `stopped` telemetry assertion still
verifies the exit reason was `:normal`.
- **`distributor/readoption_test.exs`** (run 29447945622):
`:sys.get_state(distributor)` raced with the distributor stopping
normally — the test's expected outcome. Dropped the `get_state` (the
placeholder-vs-adopted pid distinction is covered by the earlier
sweep/re-adoption test) and applied the same `:noproc` guard to the
DOWN.
- **`olivine/genserver_integration_test.exs`** (run 29548013855): a 1 ms
`GenServer.call` intended to "succeed or timeout gracefully" wasn't
wrapped, so a real timeout on a slow runner crashed the test. Now
caught, falling through to the existing process-survives assertion.

## Testing

- All 44 tests in the three affected files pass locally.
- `mix format --check-formatted` and `mix credo` clean on the changed
files.

Closes bedrock-yp2.

6343 of 8439 relevant lines covered (75.16%)

912.65 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5789085b87620d5c89d81b701d098880b1748803.1 225
75.16
 GitHub Action Run
Source Files on build 5789085b87620d5c89d81b701d098880b1748803