archetech / archon / 29537246159

90%

main: 90%

Pull #734

github

fix: error when asset bytes are unavailable instead of falling back to JSON

Review catch, and a real one. getFile returns null only when the asset is not a
file asset; when the gatekeeper cannot fetch the CID it returns the file asset
*without* data. Gating on file?.data collapsed those two, so a file DID whose
bytes were unavailable answered a request for bytes with the asset's metadata
as application/json -- reporting an infrastructure failure as a successful read
and contradicting the documented behaviour.

Branch on the file asset itself and throw when its bytes are missing; the JSON
fallback now only covers assets that are genuinely not file or image assets.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2946 of 3494 branches covered (84.32%)

Branch coverage included in aggregate %.

16 of 18 new or added lines in 3 files covered. (88.89%)

6133 of 6559 relevant lines covered (93.51%)

835.72 hits per line