archetech / archon / 29531474139

90%

main: 90%

Build Type

Pull #732

github

Committed by macterra

Commit Message

fix: mirror keymaster's wallet type guards, correct the union comment

Review catches, both valid, and following the first one found a real gap.

The "disjoint" claim was wrong: both union branches passthrough, so an object
carrying `enc` alongside counter/ids satisfies either and the first branch
wins. The code was right for the wrong stated reason -- encrypted must come
first, which is what keymaster does too (isWalletEncFile keys on `enc` being a
string; isWalletFile requires !('enc' in obj)), so a hybrid is treated as
encrypted by both the schema and the method behind it. Comment now says that.

Reading those guards showed the schema was mirroring the WalletFile *type*,
which disagrees with them: the type marks `version` optional, but both guards
require version 1|2 AND seed.mnemonicEnc. The schema accepted wallets keymaster
would reject with "Unsupported wallet version." deeper in -- exactly the failure
this PR exists to prevent. Both are now required, which is not stricter than
keymaster, just earlier. The fixtures that broke were wallets with `seed: {}`
that keymaster would have refused.

Also: restore's description said "encrypted wallet payload" while the schema
accepts encrypted or plaintext. It reads it before choosing arguments.

counter/ids stay required -- the one place stricter than the runtime guard,
since the type declares them and newWallet always writes them.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #732: feat: author real input schemas for structured-object tools (#727)

Coverage Stats

2940 of 3486 branches covered (84.34%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

6120 of 6544 relevant lines covered (93.52%)

837.1 hits per line