wol-soft / php-json-schema-model-generator-production / 29530702040

45%

master: 46%

Build Type

Pull #19

github

Committed by claude

Commit Message

Make enum/const messages self-descriptive

EnumException and InvalidConstException were the only constraint violations
that didn't say what would have satisfied them — "declined by enum
constraint" / "declined by const constraint" gave no indication of the
allowed/expected value or what was actually provided, unlike every other
constraint (Minimum, MaxLength, Pattern, Format, ...), which states its
bound directly in the message. Both getters (getAllowedValues(),
getExpectedValue()) already existed, but reading them meant an extra call
just to explain a common failure.

Messages now read "Value for 'x' must be <expected>, got <got>" (const) /
"... must be one of [<allowed>], got <got>" (enum). Values render through a
shared ValueFormatter (json_encode-based, with a var_export fallback for
values json_encode can't handle) since these are constraints on JSON data —
scalars, arrays, and objects all render consistently rather than needing
separate handling. Enum's allowed-values list is capped at 8 entries before
truncating to a 5-item preview + count, so a large enum doesn't turn the
message into a single unreadable line.

Pull Request Pull Request #19: Fix nested composition indentation + add data-instance JSON pointer (issue #131)

Coverage Stats

79 of 81 new or added lines in 11 files covered. (97.53%)

1 existing line in 1 file now uncovered.

392 of 849 relevant lines covered (46.17%)

1.57 hits per line