immerjs / immer / 29525056981

46%

push

github

fix: throw proper immer error when applyPatches path traverses null (#1251)

typeof null === "object" causes isObjectish(null) to return true,
silently bypassing the path-resolution guard inside applyPatches_.
Traversal then calls getArchtype(null) which accesses null[DRAFT_STATE]
and crashes with a native TypeError instead of immer error 18
("Cannot apply patch, path doesn't resolve").

Add an explicit null check alongside isObjectish so the guard fires
correctly and the caller receives the expected immer error message.

Fixes: applyPatches({a: null}, [{op: 'add', path: ['a', 'b'], value: 1}])

Co-authored-by: JSap0914 <JSap0914@users.noreply.github.com>

658 of 706 branches covered (93.2%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1718 of 4491 relevant lines covered (38.25%)

1871.04 hits per line