operator-framework / operator-sdk / 29469156369

31%

master: 31%

Pull #7114

github

Fix scorecard descriptor test panic on non-object CR spec/status

The scorecard olm-spec-descriptors, olm-status-descriptors and
olm-crds-have-validation tests read a CR's spec and status from a
bundle's alm-examples annotation and type-assert them to
map[string]any while only guarding against nil. A bundle whose CR
has a spec or status that is a JSON scalar or array instead of an
object (for example "spec": "foo") makes the unguarded assertion
panic with "interface conversion: interface {} is string, not
map[string]interface {}", crashing the scorecard test binary on
malformed or untrusted bundle content.

Use comma-ok assertions at all four sites so a non-object spec or
status is handled the same as a missing one: the spec-descriptors
check reports a failed descriptor, and the status/validation checks
skip the field cleanly. Add regression tests that drive the real
check functions with a scalar spec and an array status and assert
they do not panic.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>

9 of 9 new or added lines in 1 file covered. (100.0%)

4381 of 13947 relevant lines covered (31.41%)

13.44 hits per line