mostafa / xk6-kafka / 29491525924

79%

push

github

fix: clear TLSNextProto on schema registry transport when TLS is configured (#404)

* fix: clear TLSNextProto on schema registry transport when TLS is configured

The gzipTransport wrapper (added in #363) is bypassed when TLS is configured
because Clone() of http.DefaultTransport copies TLSNextProto (the HTTP/2
protocol handler map). Setting TLSClientConfig on the clone without clearing
TLSNextProto causes HTTP/2 to be negotiated via ALPN, but the cloned transport
has no own h2 connection pool. The h2 frames reach gzipTransport which
interprets the binary framing as gzip, causing:
  invalid character '\x1f' looking for beginning of value

Fix: clear TLSNextProto after setting TLSClientConfig to force HTTP/1.1,
which is what gzipTransport was designed for.

Also restructures the nil-check to early-return before the Clone path, and
adds unit tests for both the TLS and non-TLS transport construction paths.

* style: fix line length in TestNewSchemaRegistryTransportWithTLS assertion message

9 of 9 new or added lines in 1 file covered. (100.0%)

3854 of 4898 relevant lines covered (78.69%)

43.88 hits per line