spdx / tools-golang / 29457529062

87%

main: 87%

Pull #292

github

rdf: check endPointerTriples in the snippet range end pointer guard

The guard ahead of endPointerTriples[0] tests len(startPointerTriples)
instead, which the previous block has already validated, so it always
passes. Its own error message says endPointer, which is what it was
meant to check.

A range node with a valid startPointer and no endPointer clears every
earlier check (3 associated triples, exactly 1 rdf:type, exactly 1
startPointer) if the third triple is some other predicate, and then
indexes an empty slice. That panics the parser on malformed RDF input
rather than returning the intended error.

Same line was wrong in v2_2 and v2_3, so both are fixed here.

The existing 0-endPointer test case actually had two endPointers and no
startPointer, so it tripped the startPointer guard and never reached
this branch. Rewrote it to match what it says it covers.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>

2 of 2 new or added lines in 2 files covered. (100.0%)

7578 of 8759 relevant lines covered (86.52%)

18.56 hits per line