OpenRefine / OpenRefine / 29457255702

50%

push

github

fix: stabilize facets e2e test against race condition on CI (#7846)

* fix: stabilize facets e2e test against race condition on CI

The "Test include/exclude filters" test was failing in CI with:
  CypressError: Timed out retrying after 4050ms: cy.click() failed because
  the page updated while this command was executing.

Root cause: Refine.update() runs two sequential AJAX calls after a facet
action: get-rows (grid) then compute-facets (facets). The test assertions
(cy.getCell, #tool-panel) pass when get-rows completes, starting the
150 ms wireEvents wait—but compute-facets may still be in-flight in CI.
When it finishes, it replaces the facet DOM, detaching elements that
Cypress was about to click.

Fixes:
1. Add cy.get('body[ajax_in_progress="false"]') after assertions in each
   include/exclude step to guarantee compute-facets has completed before
   the 150 ms wireEvents countdown begins.
2. Fix clickFacetAction helper to use scoped .parent().find() instead of
   the broken .siblings().get() pattern (get() is a global DOM query,
   not scoped to siblings).

* fix: add Java 21 setup step to codeql_javascript.yml workflow

Mirrors the fix applied in codeql_java.yml (commit ad14134): the
./refine build step requires Java 21, so the JavaScript CodeQL workflow
also needs a setup-java step before initializing CodeQL.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

5692 of 12972 branches covered (43.88%)

Branch coverage included in aggregate %.

14564 of 27598 relevant lines covered (52.77%)

2.65 hits per line