decentraland / worlds-content-server / 29444119097

89%

main: 91%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

fix: harden partial-deployment finalize, GC, and staging hot path

correctness / security:
- deployScene: exclude the entity's own row from the overlap soft-delete, so
  a concurrent finalize (or client retry) of an already-deployed entity
  collides on the world_scenes primary key (the idempotency signal) instead
  of soft-deleting then re-deploying — which double-published the SNS event
  and double-counted the deployment
- verify the auth-chain signature over the entity id BEFORE reading the
  entity back from storage on a resume request, so an unauthenticated caller
  can't make the server retrieve and buffer up to 10mb per request (the
  resume read is not covered by the multipart in-flight budget)
- garbage collection: also subtract the keys of scenes deployed since the
  sweep began, so a partial upload that finalizes mid-sweep (pending row
  gone, world_scenes snapshot stale) can't have its reused content reclaimed
- apply the 10mb entity-file cap only on the partial path; the vanilla
  single-request path is bounded by the multipart budget, so capping it there
  wrongly rejected large-but-legitimate manifests that deployed before

performance / cleanup:
- stop shipping the multi-mb entity jsonb between postgres and node on every
  staging batch: drop it from the getByEntityId select and the upsert
  returning (no caller reads it), and only insert it on the first batch — a
  resume just bumps updated_at
- run the independent pending-row and content-metadata lookups concurrently
- drop the redundant storage head on the resume path (the capped read
  enforces the size limit on its own)
- fix a stale finalization-lease comment and a vacuous self-exclusion in the
  per-deployer cap count

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

1489 of 1795 branches covered (82.95%)

Branch coverage included in aggregate %.

198 of 223 new or added lines in 12 files covered. (88.79%)

4 existing lines in 3 files now uncovered.

3170 of 3459 relevant lines covered (91.64%)

95.3 hits per line