uc-cdis / cohort-middleware / 29443951916
81%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 28
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.389% (+0.9%) from 80.479%
29443951916

push

github

web-flow 
Feat: validate source access for team (#142)

* feat: add new TeamProjectValidationForSourceId validation method

* fix: remove unnecessary clause in GetAllSourcesWithTeamProject

* feat: using TeamProjectValidationForSourceId in cohortdata endpoints

* feat: using TeamProjectValidationForSourceId in cohortdefinition and concept endpoints

* fix: fix calls to NewTeamProjectAuthz to include new ref to source model

* fix: merge TeamProjectValidation logic for source and cohorts

* fix: fix controller tests to include updated authz method signatures with sourceId

* fix: fix middleware tests to include updated authz method signatures with sourceId

* fix: adjusted test data and dev config parsing to allow for local testing of endpoints

* fix: use source_id for source filtering

* feat: improve code comments, security of some methods, reused parsing method

* fix: add missing parameter error handling

* feat: added tests for new parsing methods

* feat: support sourceId in DataDictionary endpoints

* fix: change CurrentTeamProjectAccessible to real boolean

* feat: adjust /_schema_version endpoint to return version info on all sources

* feat: improve tests by adding two active sources to test data used in models tests

* feat: extra test for TeamProjectValidationForSourceIdAndCohortIdsList

* fix: address linting issue in utils_test.go

* feat: small logic fix

* feat: improve test for GetAllRoleNamesWithSourceGeneratePermission

185 of 270 new or added lines in 11 files covered. (68.52%)

5 existing lines in 3 files now uncovered.

2449 of 3009 relevant lines covered (81.39%)

29.23 hits per line

Uncovered Changes

Lines Coverage ∆ File
30
62.99
 -3.22% controllers/concept.go
28
80.39
 -5.83% controllers/cohortdata.go
7
93.52
 -6.48% middlewares/teamprojectauthz.go
6
79.67
 1.22% controllers/cohortdefinition.go
6
0.0
 0.0% server/router.go
3
44.83
 -1.6% middlewares/auth.go
3
91.3
 -3.82% models/version.go
2
96.45
 35.84% models/source.go

Coverage Regressions

Lines Coverage ∆ File
2
79.67
 1.22% controllers/cohortdefinition.go
2
62.99
 -3.22% controllers/concept.go
1
80.39
 -5.83% controllers/cohortdata.go
Jobs
ID Job ID Ran Files Coverage
1 29443951916.1 28
81.39
 GitHub Action Run
Source Files on build 29443951916