ben-manes / caffeine / #5645

100%

master: 100%

push

github

Record a putIfAbsent miss for an absent zero-creation-expiry key

putIfAbsent derived its hit/miss from whether a value was stored, so an
absent key under a zero-creation-expiry -- where the new value is
immediately expired and not stored -- recorded a hit instead of a miss.
The JSR-107 statistics table counts a putIfAbsent miss whenever the key
is absent, independent of whether anything was stored; getAndPut already
classifies off prior-presence and gets this right.

Thread prior-presence out of putIfAbsentNoAwait (a present flag set in
the live-mapping branch) and classify the hit/miss by it, leaving the
put and put-time gated on the store. Only the zero-creation-expiry
configuration is affected; the normal, present, and expired-under-normal
cases were already correct.

Pinned by a strengthened JCacheCreationExpiryTest case asserting the
absent zero-creation-expiry putIfAbsent records a miss, not a hit.

4155 of 4164 branches covered (99.78%)

10 of 10 new or added lines in 1 file covered. (100.0%)

8422 of 8422 relevant lines covered (100.0%)

1.0 hits per line