kubevirt / containerized-data-importer / #6115

50%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

add insecureSkipVerify to http source type (#4167)

* Adding new "insecureSkipVerify" option for http datasources
This option allows a user to explicitly override TLS for self-signed certificates on specific data sources
This option uses existing framework for overriding TLS settings in storageio importer for consistency
All existing go tests have been updated to use the default setting "false" to maintain the existing tests

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

* updated tests to check for working insecureSkipVerify

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

* adding in functional test

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

* updating docs to reflect the new insecureSkipVerify option

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

* simplifying the datavolume functional test

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

* adding in unit test for validating proper handling of AnnInsecureSkipVerify

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

* added unit test to import-controller around isSecureTLS function

Signed-off-by: Mark DeNeve <3779715+xphyr@users.noreply.github.com>

* working on new tests, still not quite there yet

Signed-off-by: Mark DeNeve <3779715+xphyr@users.noreply.github.com>

* fixed the issue with my first unit test

Signed-off-by: Mark DeNeve <3779715+xphyr@users.noreply.github.com>

* working on new tests, still not quite there yet

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

* adding in additional tests from @akalenyu

Signed-off-by: xphyr <xphyr@users.noreply.github.com>

---------

Signed-off-by: xphyr <xphyr@users.noreply.github.com>
Signed-off-by: Mark DeNeve <3779715+xphyr@users.noreply.github.com>
Co-authored-by: xphyr <xphyr@users.noreply.github.com>

Coverage Stats

9 of 10 new or added lines in 4 files covered. (90.0%)

11 existing lines in 1 file now uncovered.

15162 of 30416 relevant lines covered (49.85%)

0.56 hits per line