kubernetes-sigs / karpenter / 29436793702

82%

main: 82%

Build Type

Pull #2894

github

Committed by nathangeology

Commit Message

test(deletioncost): cover non-RS-owned pods in ranking_test

Per ryan-mist review comment r3585309512: add coverage for the
hasNonRSOwnedPods Group A predicate. The direct-helper Edge context
grows a DescribeTable that walks the interesting owner-kind variants
(bare pod, StatefulSet, Job, DaemonSet) and asserts each classifies
into Group A or NOT Group A per the RFC's Group A definition, plus a
standalone case pinning the kube-system exemption for unowned system
pods (coredns, kube-proxy).

The classification is only observable at the direct-helper boundary;
the reconcile-path annotation value doesn't distinguish "Group A
because disrupted" from "Group A because non-RS-owned pod on the
node" — both land at math.MinInt32. Reconcile-level tests already
cover the Group A -> MinInt32 path via disrupted+PDB-blocked; these
new tests pin the specific hasNonRSOwnedPods predicate that would
otherwise regress silently.

Pull Request Pull Request #2894: feat: Add feature-gated pod deletion cost management controller

Coverage Stats

443 of 502 new or added lines in 8 files covered. (88.25%)

1 existing line in 1 file now uncovered.

16860 of 20450 relevant lines covered (82.44%)

97440.36 hits per line