stacklok / toolhive / 29428067019

68%

Build Type

push

github

Committed by web-flow

Commit Message

Add Codex App LLM setup support (#5810)

* Add Codex App LLM setup support

Detect Codex desktop installations on macOS and Windows so app-only users can configure the shared Codex model provider through thv llm setup. Keep one canonical Codex configuration and teardown path for both the CLI and desktop app.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Address review comments on Codex desktop detection

- Log detector errors at WARN instead of silently swallowing them
- Invoke plutil by absolute path (/usr/bin/plutil) to avoid PATH
  resolution failures in stripped environments
- Refactor to a per-client LLMInstalledDetector hook, removing the
  hardcoded Codex branch and duplicated CLI detection logic
- Guard lookPath consistently in the shared detection path
- Tighten the #nosec G204 justification

---------

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

Coverage Stats

93 of 102 new or added lines in 4 files covered. (91.18%)

23 existing lines in 6 files now uncovered.

73731 of 108265 relevant lines covered (68.1%)

63.88 hits per line