stacklok / toolhive-studio / 29422203688

71%

main: 71%

Pull #2469

github

fix: revert unsupported IPv4 host validation, collapse empty allow-lists

The backend's Squid rule builder only ever emits a dstdomain ACL for
allow_host entries (pkg/container/docker/squid.go), with no branch for
IP-shaped values, so accepting IPv4 addresses client-side promised
something the backend can't reliably enforce. Reverts to domain-only
host validation and removes the "or IP addresses" tooltip claim.

Also addresses review feedback on the Network access tab layout
(James Tenniswood): the Allowed hosts/ports sections no longer show an
empty add-a-host/add-a-port list by default, which read as if both
were required. DynamicArrayField gains an opt-in collapseWhenEmpty
mode that keeps the section title visible but only shows the add
button until the user adds an entry, revealing the input row at that
point.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

5402 of 8126 branches covered (66.48%)

45 of 45 new or added lines in 5 files covered. (100.0%)

7841 of 11012 relevant lines covered (71.2%)

140.65 hits per line