stacklok / toolhive-studio / 29406991485

71%

main: 71%

Build Type

Pull #2469

github

Committed by kantord

Commit Message

fix: make network isolation mode explicit instead of inferred

Studio always sent `network_isolation: false`, silently overriding the
backend's new default of isolating new workloads. A prior attempt (#2332)
derived `insecure_allow_all` from whether the allow-list arrays were empty,
but reviewers flagged that as ambiguous — it couldn't distinguish "isolate
with no restrictions" from "isolate and block everything".

Replaces the boolean toggle with an explicit `networkAccess` mode (none /
host / proxy) and an explicit `allowedDestinations` (anywhere / selected)
field that drives `insecure_allow_all` directly, consolidates the duplicated
tab-content components into one, and wires up the previously-unused
`permission_profile.network.mode: "host"` backend field.

Closes #2326

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #2469: fix: make network isolation mode explicit instead of inferred

Coverage Stats

5384 of 8111 branches covered (66.38%)

40 of 41 new or added lines in 6 files covered. (97.56%)

13 existing lines in 2 files now uncovered.

7837 of 11008 relevant lines covered (71.19%)

139.42 hits per line