dangernoodle-io / breadboard / 29389803401

96%

push

github

refactor: rehome bb_nv SSOT headers to bb_config (B1-958) (#879)

bb_nv_namespaces.h and bb_nv_keys.h were already neutral cross-component
SSOT headers (namespace/key strings owned by bb_system, bb_net_health,
bb_mqtt_client, etc., not bb_nv) that just physically lived in the dying
bb_nv component's include dir. Pure move, no value changes -- NVS
byte-compat preserved.

- moved both headers to bb_config/include/, the one existing dependency
  every direct consumer (bb_ota_boot, bb_net_health, bb_tls_creds,
  bb_system, bb_diag) already privately required, avoiding any new
  dependency edges
- dropped bb_nv from PRIV_REQUIRES in all five consumers now that the
  headers no longer live there
- removed a dead, unused #include "bb_nv.h" in bb_diag_routes.c that
  was blocking the drop
- bb_nv.h no longer transitively includes bb_nv_namespaces.h (no
  consumer relied on that); bb_nv.c now includes it directly and picks
  up a new PRIV_REQUIRES bb_config for its own NVS reads
- bb_nv no longer owns these headers, clearing the way for its deletion
  (B1-964)


Claude-Session: https://claude.ai/code/session_01V5JXJNaYWPwjrcS8nk183m

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

6972 of 7603 branches covered (91.7%)

Branch coverage included in aggregate %.

11686 of 11938 relevant lines covered (97.89%)

2416.05 hits per line