loopbackio / strong-soap / 29387437041

85%

push

github

fix: default SOAP Fault responses to HTTP 500

A service method that replies with a SOAP Fault was served with HTTP status
code 200, which breaks HTTP-level error handling for clients and proxies. Per
the SOAP spec a fault should carry a 5xx status. Default the response to HTTP
500 when a Fault has no explicit statusCode; an explicit Fault.statusCode still
overrides and is not serialized into the Fault XML.

Fixes #346

Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

1510 of 1952 branches covered (77.36%)

Branch coverage included in aggregate %.

2899 of 3249 relevant lines covered (89.23%)

15422.35 hits per line