dangernoodle-io / breadboard / 29385541001

96%

push

github

refactor: bb_mqtt_client owns its NVS namespace/key constants internally (B1-949) (#877)

bb_mqtt_client stops borrowing bb_nv's shared SSOT namespace/key constants
(BB_MQTT_NVS_NS/BB_NV_KEY_CLIENT_ID) and internalizes them in a new private
header (src/bb_mqtt_client_nvs.h), renamed to signal ownership
(BB_MQTT_CLIENT_NVS_NS/BB_MQTT_CLIENT_NVS_KEY_CLIENT_ID). Values are
byte-identical ("bb_mqtt"/"client_id") -- this is a pure ownership move, not
an NVS format change, so provisioned-board MQTT config is unaffected.

Both backends already read/write mqtt config via bb_config (zero bb_nv KV
calls remain), so bb_nv drops from REQUIRES/PRIV_REQUIRES entirely.

- drop the public-header leak of bb_nv_namespaces.h from bb_mqtt_client.h
- espidf/host backends include the new private header instead of
  bb_nv_keys.h / relying on the public header's transitive include
- move the byte-compat guard assertions for these two constants out of
  test_nv_generic.c into test_bb_mqtt_client.c (bb_nv no longer owns them)

6962 of 7597 branches covered (91.64%)

Branch coverage included in aggregate %.

11674 of 11929 relevant lines covered (97.86%)

2417.68 hits per line