openmrs / openmrs-core / 29373009385

64%

master: 65%

Build Type

push

github

Committed by web-flow

Commit Message

TRUNK-6516: Fix outbox/broker issues found in events/CDC sign-off (#6298) (#6313)

Backport of #6298 to 2.9.x, adapted to the 2.9.x platform (javax
persistence / Hibernate 5 / Spring 5). Addresses findings 1, 2, 4, 5, 7
from the sign-off issue.

- Finding 1: OutboxEventRegistry now owns the scheduler lifecycle. It
  triggers OutboxTaskSchedulerInitializer.schedule()/deleteScheduledTasks()
  after scanning listener beans, guaranteeing the poller only starts once
  listeners are known. OutboxTaskSchedulerInitializer no longer implements
  SmartInitializingSingleton and no longer references OutboxEventRegistry.
- Finding 2: Use Context.loadClass() instead of Class.forName() in
  OutboxPollingTaskHandler so module-defined event types resolve.
- Finding 4: Change outbox_event.payload and completed_listeners from TEXT
  to MEDIUMTEXT in the update changelog and align the OutboxEvent entity
  columnDefinition. HibernateAdministrationDAO now treats LONGTEXT and
  MEDIUMTEXT columns as unbounded so ValidateUtil accepts large payloads.
- Finding 5: BrokerEventListenerFactory rejects wildcard/raw
  BrokerIncomingEvent at registration time instead of dead-lettering.
- Finding 7: Document on OpenmrsServiceEventAdvice that a synchronous
  @EventListener exception aborting the service call is intentional.

The 2.9.x liquibase schema-only snapshot does not exist yet, so only the
update changelog carries the MEDIUMTEXT change. Context.java javadoc link
updated to OutboxTaskSchedulerInitializer#schedule().

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

19 of 27 new or added lines in 5 files covered. (70.37%)

15 existing lines in 5 files now uncovered.

24113 of 37770 relevant lines covered (63.84%)

0.64 hits per line