ben-manes / caffeine / #5637

100%

master: 100%

push

github

Publish an EntryProcessor's expired prior before the processor runs

Mirror BoundedLocalCache's evict-before-callback ordering in the jcache
invoke path. A lazily-expired prior is reconciled inline before the
processor runs: it publishes EXPIRED and counts the eviction up front,
then the processor sees the entry as absent. On any Throwable from the
processor or a write-through CacheWriter, the expired prior's removal is
committed, its synchronous EXPIRED listener is awaited, and the failure
is rethrown after the compute returns (catch-commit-rethrow) via
processorFailure -- an Error as-is, otherwise an EntryProcessorException
per Cache.invoke's contract. So a failed invoke still fires exactly one
EXPIRED and one eviction; the expiration is a clock fact, not contingent
on the operation succeeding.

postProcess is now expiry-free: a null prior means the entry was absent,
so READ/UPDATED (which require a live prior) never observe one and their
requireNonNull is a proven invariant. This drops the hoisted null that
made READ/UPDATED look NPE-prone (superseding #1992) and the
currentTimeMillis == 0 re-read sentinel.

Tests: postProcess reduced to 2-arg replay plus an eternal invoke guard
(isEternal shields hasExpired from a negative-clock overflow); and
invoke-level guards for an expired prior under create, remove, a thrown
RuntimeException and Error, an awaited synchronous listener on the async
executor, and EXPIRED-before-CREATED ordering. Verified with
:jcache:test and :jcache:tckTest.

4137 of 4148 branches covered (99.73%)

24 of 26 new or added lines in 1 file covered. (92.31%)

8411 of 8414 relevant lines covered (99.96%)

1.0 hits per line