bedrock-kv / bedrock / d2001662f36cdcc61a752934b53c9eefb54de6ea

73%

Build Type

push

github

Committed by web-flow

Commit Message

Add behavioral tests for Repo transaction lifecycle + fix rollback/1 crash (bedrock-60h, bedrock-j64) (#86)

## Summary
- Adds `repo_transact_test.exs` with 24 tests for `Internal.Repo`
(coverage 81.4% → 99.7%): the cast-based in-transaction API with exact
message assertions, `transact` lifecycle (nested transactions, commit
result variants, arity-0/1 funs), retry machinery
(fail-once-then-succeed with exact attempt counts, retry-limit
RuntimeError, rollback-on-exception with reraise), and TSL fetch via
provided layout vs cluster link
- **Fixes a real crash bug (bedrock-j64)**: `MyRepo.rollback(reason)`
inside `transact` — the *documented* usage — escaped as an uncaught
throw and never rolled back the builder, because the catch clause
matched a 4-tuple shape nothing in the codebase throws. Fixed to catch
the real 3-tuple and roll back the current transaction; returns
`{:error, reason}` per the docs.

## How it's tested without cluster infrastructure
A real TransactionBuilder against a minimal TSL (`%{epoch: 1, proxies:
[]}`) gives deterministic end-to-end commit paths: empty transactions
local-commit `{:ok, 0}`, mutation commits fail `{:error, :unavailable}`
— both deliberate code paths, audit-verified as stable seams.
Nested/rollback flows use a scripted stub builder seeded in the process
dictionary.

## Audit
Independent review verified the fix empirically (revert → exactly the
two rollback tests fail with the uncaught throw), confirmed the 4-tuple
is thrown nowhere, and traced nested-rollback semantics through
`Finalization.rollback/1` (pops exactly one stack layer; outer
transaction survives). Non-blocking suggestions noted in review: add
`retry_limit: 1` to the three TSL happy-path tests to fail fast if the
local-commit shortcut ever changes, and drop a no-op `on_exit`.

## Test plan
- 24/24 green at multiple seeds; full test/bedrock/internal/ (443 tests)
green; full suite (2370 tests, 158 properties) green

Tickets: bedrock-60h, bedrock-j64

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

5553 of 7838 relevant lines covered (70.85%)

1981.89 hits per line