bedrock-kv / bedrock / 057dac132d2bb9ab0eb9584b42b0e90d8cf3ad6e

73%

Build Type

push

github

Committed by web-flow

Commit Message

Add behavioral tests for Directory partition operations (bedrock-ej0) (#88)

## Summary
- Adds `directory_partition_test.exs` (28 tests) for `Bedrock.Directory`
(coverage 92.5% → 99.1%)
- Instead of canned Mox expectations, tests run directory operations
end-to-end against an Agent-backed in-memory store that byte-for-byte
mirrors `Bedrock.Repo`'s keyspace pack/get_range semantics — covering
partition-scoped ops, path-escape validation (`..`), create_or_open
flows, accessors, `ToKeyRange`/`ToKeyspace` protocol impls, and all
node-value encoding variants via real round-trips

## Bugs found (audit-confirmed against real modules, tickets filed)
1. **Critical — directory hierarchy scans are blind to descendants
against any real store.** `Encoding.Tuple.pack/1` wraps top-level lists
in a nested-list tag, so a packed node key (`["app"]`) is NOT a
byte-prefix of its child (`["app","users"]`) — diverges at the
list-terminator byte. Consequently non-root `Directory.list` returns
`[]` regardless of children, `remove` orphans descendants, and `move`
misses them. Root works only because `pack([]) = <<>>`. Every existing
directory test masks this with canned `get_range` mocks that return
descendants unconditionally.
2. **`do_move_recursive` crashes against the real repo before the prefix
issue even matters**: it calls `repo.get_range(start_key, end_key)` with
two binaries, which the generated repo parses as `(range, opts)` →
`FunctionClauseError` in `Keyword.get`. Same shape for `clear_range`.

The new tests are deliberately honest about this: they assert only
currently-correct behavior (root list, leaf remove/move) rather than
pinning the broken paths.

## Audit
Independent review reproduced the prefix divergence and range exclusion
by executing lib code directly (no mocks), traced the production
plumbing `do_list` uses, and verified nothing in livebooks/bedrock_ex
exercises non-root hierarchy ops (why it went unnoticed). Store fidelity
verified against `repo.ex`... (continued)

Coverage Stats

7 of 7 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

5445 of 7835 relevant lines covered (69.5%)

1966.02 hits per line