bedrock-kv / bedrock / 4bf909e910c0d2d1c5c9c17dda5b6c5c4e22799a
73%

DEFAULT BRANCH: develop
Ran
Jobs 2
Files 215
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.182% (+1.4%) from 65.752%
4bf909e910c0d2d1c5c9c17dda5b6c5c4e22799a

push

github

web-flow 
Add behavioral tests for Olivine Logic (bedrock-eu4) (#80)

## Summary
- Extends `logic_test.exs` with 14 new tests (13 → 27) for
`Olivine.Logic` (coverage 81.1% → 93.0%)
- Covers info/2 fact gathering (all supported facts, unsupported fact,
list form), apply_transactions (version propagation, read-back,
overwrite, MVCC visibility at older versions), advance_window
(no-eviction, deterministic eviction via version arithmetic, and the
version-underflow rescue clamping the telemetry window edge to zero),
start_compaction's full 12-element `:compaction_ready` message contract,
and maybe_upload_snapshot (nil no-op + real upload via the
LocalFilesystem object-storage backend, no minio/network)

## Audit
An independent reviewer pass confirmed determinism (eviction is pure
version arithmetic, no wall clock; runs green at 4 seeds), resource
hygiene, and strengthened one vacuous assertion (`:supported_info` now
must advertise the 11 core facts). Remaining uncovered lines are error
branches only (`advance_durable_version` failure, compaction-failed,
upload-failure logging).

Follow-ups filed: info/2 double-wraps errors (`{:ok, {:error,
:unsupported_info}}`) while its @spec claims an unreachable top-level
error return; `create_transaction/2` is now duplicated across 7 olivine
test files and should move into `TransactionTestSupport`.

## Test plan
- 27/27 green at multiple seeds; full suite (2311 tests, 158 properties)
green

Ticket: bedrock-eu4

5263 of 7834 relevant lines covered (67.18%)

1956.37 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
87.18
 -1.1% lib/bedrock/data_plane/transaction.ex
Jobs
ID Job ID Ran Files Coverage
1 4bf909e910c0d2d1c5c9c17dda5b6c5c4e22799a.1 215
67.14
 GitHub Action Run
2 4bf909e910c0d2d1c5c9c17dda5b6c5c4e22799a.2 215
67.05
 GitHub Action Run
Source Files on build 4bf909e910c0d2d1c5c9c17dda5b6c5c4e22799a