pantsbuild / pants / 29354462321

Build # 29354462321

Build Type

push

github

Committed by web-flow

Commit Message

use a dedicated render thread for indicatif spinner (#23279)

Previously we had the classic combination of doing "real work" and
trying to keep a UI snappy on the same (scheduler) thread. This results
in jittery spinners that can be sluggish under load.

This change splits it out so there is a dedicated render thread. This
matches the architecture used by the `experimental-prodash` renderer.
The "obvious" alternative to get a steady tick would be
`enable_steady_tick`, but that was rejected in #19931 due to desync
concerns.

Using the large repo from #23236

```
$ asciinema record data/baseline.cast --command  '_PANTS_VERSION_OVERRIDE=2.31.0 PANTS_DEBUG= /home/ecsb/src/o/pants-trees/baseline/pants --no-pantsd --changed-since=HEAD~1 --changed-dependents=transitive list'
```

baseline: https://asciinema.org/a/b67xISILRXqBQl4U

after: https://asciinema.org/a/DK0s3SB6ISjab6ji

Notice: I used a LLM to try a variety of approaches to reduce jitter and
to write the code for this particular restructuring. It is both the most
clearly helpful, and a building block for anything else. I also used a
LLM to write a script to analyze asciinema logs, but in this case the
visual outcome was obvious.

Coverage Stats

94605 of 101754 relevant lines covered (92.97%)

3.68 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available