dangernoodle-io / breadboard / 29353850718

96%

push

github

refactor: migrate bb_mqtt_client/bb_net_health/bb_ota_boot off bb_nv generic KV (B1-756) (#865)

Moves the second slice of bb_nv generic-KV consumers onto bb_config (the
typed layer over bb_storage), following PR #864's pattern for
bb_tcp_client/bb_udp_client/bb_tls_creds.

Preserved namespaces/keys/types (byte-compatible on-flash, no format change
-- bb_nv's ESP-IDF forwarders and bb_config's typed encodings both resolve
to the same underlying bb_storage_nvs_* / nvs_* calls):
  - bb_mqtt_client: ns "bb_mqtt", keys "enabled"/"uri"/"client_id"
    (BB_NV_KEY_CLIENT_ID)/"username"/"password"/"tls" -- all STR-typed,
    unchanged (espidf autoregister path + host resume_default's uri reload)
  - bb_net_health: ns "bb_egress_act", key "state" (STR, packed reboot-state
    string) -- espidf-only egress-recovery ACT gate (CONFIG_BB_NET_HEALTH_
    EGRESS_ACT_ENABLE)
  - bb_ota_boot: ns "bb_cfg" (BB_NV_CONFIG_NVS_NS), key "ota_boot_mode" (U8,
    one-shot boot-mode flag)

NUL-termination (B1-756 trap 1): all bb_mqtt_client destination buffers are
zero-initialized (`= {0}` / string-literal-initialized arrays) before the
bb_config_get_str call, so no explicit fix was needed there. bb_net_health's
egress_act_load_state buf is a stack-local `char buf[...]` with NO
initializer -- bb_config_get_str's blob-fallback path does not itself
NUL-terminate (unlike bb_nv_get_str's prior bb_strlcpy-based guarantee), so
a short/truncated read could leave the subsequent bb_net_health_reboot_state_decode
call scanning uninitialized stack. Added an explicit bounded terminate keyed
off the reported out_len, mirroring bb_tls_creds' PR #864 fix.

bb_ota_boot's flag is a scalar (U8), not a string, so no NUL-termination
concern applies there.

Host test coverage (B1-756 trap 3): bb_ota_boot's existing host tests
asserted only call-safety ("callable without crashing") because bb_nv's
host stub genuinely no-ops integer round-trips (bb_nv_get_u8/set_u8 always
just return the fallback on... (continued)

6899 of 7537 branches covered (91.54%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

11596 of 11865 relevant lines covered (97.73%)

2452.21 hits per line