grobidOrg / grobid / 29348786821

push

github

Fix JVM shutdown deadlock when closing JEP Python interpreters

The shutdown hook closed Jep instances from the hook thread, but JEP
only allows an interpreter to be closed by the thread that created it:
every close() threw "Unsafe close() of Python sub-interpreter" and the
interpreter was never torn down, leaving the JVM parked forever after
DeLFT evaluations completed.

- delegate the close to the executor worker thread that owns the
  Jep instance, with a bounded wait
- make the executor threads named daemons so a wedged interpreter can
  never block JVM exit
- make shutdown() idempotent via AtomicBoolean instead of synchronized,
  removing a monitor deadlock between the hook thread and the worker
- replace the busy-wait in JEPThreadPoolClassifier.run() with
  future.get() and exception propagation, matching JEPThreadPool

8920 of 25290 branches covered (35.27%)

Branch coverage included in aggregate %.

19072 of 45920 relevant lines covered (41.53%)

1.68 hits per line