decentraland / worlds-content-server / 29345193623

89%

main: 91%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

fix: address partial-deployment review findings

- add hasNewerDeployedScene to the worlds-manager test mock so the test
  project compiles again (ci was red: ts2741)
- revert the finalization lease: correctness already rests on the
  world_scenes primary key, and the lease's 2-min ttl vastly exceeds the
  client's ~7s resume budget, so a crashed/slow holder turned a
  succeeding upload into a client failure; its unfenced release could also
  clobber a live takeover's lease
- cast entity->>'timestamp' as numeric, not bigint: the schema allows a
  fractional timestamp, and the bigint cast errored every overlapping
  staging/deploy query on such a stored entity
- bound the deployment timestamp forwards (15 min tolerance) so a
  future-dated scene can't permanently win the parcels it occupies
- enforce the per-deployer pending cap only when the upsert creates a new
  row, so lowering the cap never wedges in-flight resumes
- delete a previously-undeployed self-row inside deployScene before the
  insert, so redeploying an undeployed entity no longer loops on a pk
  violation
- enforce the resume entity-file size cap while streaming, covering the
  unknown-size (null) case instead of buffering first
- delegate the new-upload ordering check to hasNewerDeployedScene and
  scope the expired-row purge to the upserted entity

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

1480 of 1789 branches covered (82.73%)

Branch coverage included in aggregate %.

182 of 212 new or added lines in 12 files covered. (85.85%)

4 existing lines in 3 files now uncovered.

3154 of 3448 relevant lines covered (91.47%)

95.21 hits per line