CBIIT / ccdi-dcc-federation-service / 29343886729
88%
main: 87%

LAST BUILD BRANCH: 1.2.0-test
DEFAULT BRANCH: main
Ran
Jobs 1
Files 97
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.77% (+0.03%) from 87.737%
29343886729

push

github

chaozhang-nci 
Count (sample_id, study_id) pairs in the diagnosis missing query

The missing query for the diagnosis-node fields (disease_phase, tumor_grade,
age_at_diagnosis, tumor_tissue_morphology) ended in count(DISTINCT sa), counting
sample NODES. Every other count in this module counts (sample_id, study_id)
pairs -- including the total query it is reported alongside.

The two agree only while each sample node reaches exactly one study, which is a
property of the current data, not a schema constraint. A sample node reaching
two studies owns two pairs: total counts 2, and if the sample has no valid
diagnosis both pairs are missing, but count(DISTINCT sa) reports 1. The pair is
then neither counted as missing nor represented in values, so a consumer reading
total - missing sees a pair that has a value when none does. In the other
direction, two nodes sharing one pair would make missing exceed total.

Dedupe to the pair and count that instead. UNWINDing the study set also enforces
"only samples with a study" structurally, which the total query requires, so the
size([...]) pattern-comprehension filter and the three OPTIONAL MATCHes it left
unused (st1, p3, st2) are dropped along with the optional_matches builder whose
only reader this was.

No count(DISTINCT sa) remains in the module: every count is now pair-unit.

Behaviour-neutral on current data (nodes == pairs): all 15 countable fields stay
byte-identical to the baseline. Measured no regression -- 0.42s -> 0.46s median,
identical min, on local Memgraph.

16966 of 19330 relevant lines covered (87.77%)

1.31 hits per line

Coverage Regressions

Lines Coverage ∆ File
24
83.82
 0.53% repositories/sample_count.py
Jobs
ID Job ID Ran Files Coverage
1 29343886729.1 146
87.74
 GitHub Action Run
Source Files on build 29343886729