benwbrum / fromthepage / 29341041227

74%

Build Type

push

github

Committed by web-flow

Commit Message

Search collection users by display name (#5688)

* Search collection users by display name

* Search collection users by display name

### Motivation
- Collection owners could not find users when only the `display_name` (profile handle) matched the search term, so include `display_name` in the search criteria to match what owners see on user profiles.

### Description
- Update `CollectionController#search_users` to include `LOWER(display_name) LIKE :search` in the query (`app/controllers/collection_controller.rb`).
- Add a request spec that verifies a user with only a matching `display_name` (`jsmith1776`) is returned by the search (`spec/requests/collection_controller_spec.rb`).

### Testing
- Static syntax checks passed with `ruby -c` for the modified files.
- Running `rspec spec/requests/collection_controller_spec.rb` was attempted but failed due to the test environment lacking a MySQL connection (`Can't connect to MySQL server on '127.0.0.1:3306'`).

Coverage Stats

2764 of 4329 branches covered (63.85%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

10986 of 14308 relevant lines covered (76.78%)

196.62 hits per line