StoneCypher / jssm / 3522d8994df25f90c532dbc5141f9f2af74f65fd

100%

master: 100%

Pull #951

github

fix(core): restore the after-timer to the restored state in deserialize (5.162.20)

deserialize() built the machine with from(), which arms the *initial* state's
`after` timer, then overwrote _state directly -- bypassing the timer lifecycle.
Two wrong results:

  - a ghost timer stayed armed for the initial state's target even when the
    restored state has no `after` (it would later fire go() and yank the machine
    out of the restored state); and
  - the restored state's own `after` was never armed, so it could never time out.

Clears the initial-state timer and arms the restored state's timer after the
state is set (clear before arm, since set_state_timeout throws if one is
pending). A deserialized machine now schedules exactly the timer its restored
state's config calls for -- the same fresh full-duration timer from()/transition
already establish.

Verified: serialize.spec.ts +3 (no ghost timer for a no-after state; the
restored state's after is armed; restoring the initial after-state arms once),
full `npm run build` green.

Closes StoneCypher/fsl#1946

2624 of 2624 branches covered (100.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

4228 of 4228 relevant lines covered (100.0%)

16217.59 hits per line