kubeflow / trainer / 29332025122

68%

push

github

feat: move enableHTTP2 setting to Configuration object (#3339)

Introduce a TLS *TLSOptions struct to the Configuration API and remove the
--enable-http2 CLI flag as a breaking change, appropriate while we are in
alpha. HTTP/2 is now controlled exclusively via cfg.TLS.NextProtos in the
config file, and stays disabled by default to mitigate CVE-2023-44487 and
CVE-2023-39325.

TLS version and cipher suite parsing is consolidated into a single
tlsconfig.Apply helper in pkg/util/tlsconfig, so the metrics, webhook, and
status servers all resolve TLS identically.

Fixes #3326

Signed-off-by: krishdef7 <gargkrish06@gmail.com>

66 of 68 new or added lines in 4 files covered. (97.06%)

2575 of 3793 relevant lines covered (67.89%)

0.79 hits per line