kubernetes-sigs / karpenter / 29330629224

82%

main: 82%

Build Type

Pull #3139

github

Committed by heyrobertchang

Commit Message

fix: treat empty feature gate values as unset instead of panicking

Helm renders unset featureGates keys as empty values (e.g. NodeOverlay=),
most commonly when `helm upgrade --reuse-values` drops defaults added in
newer chart versions, which crashed the controller at startup with
`strconv.ParseBool: parsing "": invalid syntax`. ParseFeatureGates now
falls back to the gate's default and prints a warning to stderr (the
logger is not constructed yet at parse time), while genuinely malformed
input still fails hard.

Also adds the staticCapacity and capacityBuffer defaults to the kwok
chart values, which were referenced by the deployment template but never
defined, so a default install rendered empty values and hit the same
panic.

Pull Request Pull Request #3139: fix: treat empty feature gate values as unset instead of panicking

Coverage Stats

13 of 13 new or added lines in 1 file covered. (100.0%)

7 existing lines in 1 file now uncovered.

16454 of 19988 relevant lines covered (82.32%)

98261.5 hits per line