opendefensecloud / solution-arsenal / 29322075672

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix(discovery): use strings.Cut to strip digest algorithm prefix (#694)

## What
Swap the manual `strings.Index` + slice in `SanitizeDigestLabel` for
`strings.Cut`.

## Why
Small cleanup while getting familiar with the codebase -> `strings.Cut`
is the standard library's purpose-built helper for exactly this
split-on-separator pattern, so there's no need to hand-roll it with an
index lookup

## Testing
No behavior change. Ran the existing `SanitizeDigestLabel` specs in
`helpers_test.go` (prefix stripping, sha512 prefix, empty input,
truncation, realistic sha256 digest), all 6 pass unchanged

I lso ran the wider `pkg/discovery/...` suite

```
Will run 6 of 28 specs
------------------------------
SanitizeDigestLabel should strip the algorithm prefix
/pkg/discovery/helpers_test.go:52
• [0.000 seconds]
------------------------------
SanitizeDigestLabel should strip sha512 prefix
/pkg/discovery/helpers_test.go:56
• [0.000 seconds]
------------------------------
SanitizeDigestLabel should return empty string for empty input
/pkg/discovery/helpers_test.go:60
• [0.000 seconds]
------------------------------
SanitizeDigestLabel should truncate to 63 characters
/pkg/discovery/helpers_test.go:64
• [0.000 seconds]
------------------------------
SanitizeDigestLabel should return hex as-is when no prefix and under 63 chars
/pkg/discovery/helpers_test.go:70
• [0.000 seconds]
------------------------------
SanitizeDigestLabel should handle a realistic sha256 digest
/pkg/discovery/helpers_test.go:74
• [0.000 seconds]
------------------------------

Ran 6 of 28 Specs in 0.001 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 22 Skipped
```

## Checklist
- [ ] Tests added/updated (Not needed, the existing unit tests in place
already cover this, and behavior doesn't change 😄
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

6 existing lines in 2 files now uncovered.

4334 of 5343 relevant lines covered (81.12%)

56.59 hits per line