visgl / deck.gl / 29308304842

83%

push

github

fix(core): do not write View clearColor into the picking buffer (#10431)

* fix(core): do not write View clearColor into the picking buffer

Since #9650, the View clear/clearColor props were applied to every
render target, including the picking framebuffer. Picking colors encode
object references, so clearing with a non-transparent color makes every
background pixel decode as a picked object, breaking picks within the
picking radius and logging "Picked non-existent layer" errors. Clear
with transparent black instead when picking.

* fix(core): preserve clearColor:false semantics while picking

Per review feedback, only substitute transparent black for the view's
clearColor when a color clear was actually requested. A view with
clear: true and clearColor: false still means "clear depth/stencil but
don't touch color" during picking, preserving picking data rendered by
underlying overlapping views. Add a regression test with two
overlapping views that fails if the color is force-cleared.

---------

Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>

8040 of 10150 branches covered (79.21%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

14350 of 16772 relevant lines covered (85.56%)

19128.28 hits per line