kubeovn / kube-ovn / 29299893993

28%

Build Type

push

github

Committed by web-flow

Commit Message

perf(controller): skip irrelevant service and endpointslice updates (#7037)

enqueueUpdateService only checked EnableLb and the resource version, so
any update bumping the resource version (third-party annotation churn,
status-only writes) allocated an updateSvcObject into the non-deduplicating
pointer queue and made handleUpdateService issue per-protocol
GetLoadBalancer lookups plus per-VIP LoadBalancerDeleteVip attempts for
nothing. Skip updates that leave the spec, the VIP set (cluster IPs and
the SLR/RLR VIP annotations), the VPC annotation and the deletion
timestamp unchanged. LoadBalancer services are still always enqueued
because their reconcile also depends on status.loadBalancer.ingress and
the lb-svc attachment deployment.

enqueueUpdateEndpointSlice had the same shape: only a resource-version
check, while the EndpointSlice controller refreshes metadata such as the
endpoints.kubernetes.io/last-change-trigger-time annotation, re-issuing
the whole OVN load balancer VIP transaction chain per event. Skip updates
whose endpoints, ports and owning service label are unchanged.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

17 of 17 new or added lines in 2 files covered. (100.0%)

571 existing lines in 4 files now uncovered.

16838 of 60687 relevant lines covered (27.75%)

0.32 hits per line