jhheider / penknife / 29281566581

76%

Build Type

push

github

Committed by web-flow

Commit Message

fix: don't hang the render thread on macOS online-only files (#44)

penknife launched to a blank alt-screen with a blinking cursor and would
not respond to q or Ctrl-C. The event loop was never reached: App::new
computes a sync glyph for every tracked file, reading each one with
read_to_string, *before* the first terminal.draw. On a Dropbox/iCloud
root (macOS File Provider) some files are "online-only" placeholders
(SF_DATALESS, zero data blocks); read() on one forces an on-demand
download and blocks until the provider materializes it -- forever when
the provider is offline. One such file froze startup with no way to quit.

Add fsutil::is_dataless, which checks SF_DATALESS via metadata() (a stat,
which does *not* materialize the file). The passive read paths now skip
placeholders instead of forcing a download:

- status glyphs: a dataless tracked file reports Synced (it can't have
  been edited locally without materializing; the remote poll still flags
  RemoteNewer later, same as a resident synced file);
- preview: shows an "online-only" hint; opening in $EDITOR still
  downloads on demand.

macOS-gated; a no-op elsewhere (Linux/Windows clients keep full local
copies). penknife now draws immediately and stays fully usable offline,
never forcing a cloud download while browsing.


Claude-Session: https://claude.ai/code/session_01PykYTubrtTh4te2xg71JJS

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

16 of 18 new or added lines in 2 files covered. (88.89%)

98 existing lines in 2 files now uncovered.

7152 of 9388 relevant lines covered (76.18%)

27.15 hits per line