Borewit / music-metadata / 29279180021

95%

push

github

fix(id3v2): decode UTF-16 ($01) frames with a big-endian BOM

readNullTerminatedString stripped the leading BOM and then decoded the
remainder as UTF-16LE regardless of the BOM's byte order. UTF-16 fields
that carry a big-endian BOM (0xFE 0xFF) in COMM, USLT, WXXX, GEOB, etc.
were therefore decoded byte-swapped. Pass the BOM-inclusive slice to
decodeString, which already resolves byte order from the BOM. Length
accounting is unchanged.

1604 of 1810 branches covered (88.62%)

Branch coverage included in aggregate %.

8570 of 8855 relevant lines covered (96.78%)

55484.22 hits per line