decentraland / worlds-content-server / 29271316681

89%

main: 91%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

fix: make deployment ordering and the per-deployer cap atomic

Addresses two races and a doc gap from review:

- Newest-wins was not atomic: the partial finalize checked for a newer scene and
  then deployed in a separate transaction, so a newer vanilla deploy landing in
  between was silently undeployed. Enforce ordering inside deployScene (the write
  shared by vanilla and partial finalize): a per-world advisory lock + a reject
  when a strictly-newer overlapping scene already holds the parcels, then replace
  only older ones. Drop the now-redundant, racy pre-deploy re-check in the partial
  component (the early new-upload check is kept as a fast-fail only).
- The per-deployer concurrent-pending cap was counted separately from the insert
  and the upsert's lock is per-world, so a deployer's concurrent uploads to
  different worlds could all pass the count and insert. Enforce the cap inside
  upsert's transaction under a per-deployer advisory lock (taken before the
  per-world lock, a deadlock-free order).
- Document the partial protocol in docs/openapi.yaml: the optional partial=true
  field and the 202 { missing } response, and correct the description.

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

1468 of 1764 branches covered (83.22%)

Branch coverage included in aggregate %.

163 of 181 new or added lines in 10 files covered. (90.06%)

4 existing lines in 3 files now uncovered.

3135 of 3417 relevant lines covered (91.75%)

92.73 hits per line