sds / haml-lint / 29270052965

97%

push

github

Add unsafe autocorrections (#675)

## Summary

Adds unsafe auto-correction (applied only under `-A` /
`--auto-correct-all`) to four Haml-level linters that previously flagged
issues without being able to fix them. Each correction is
behavior-preserving in the common case and **bails out (reporting
without correcting)** whenever it can't guarantee an equivalent rewrite.

Along the way, two latent bugs were found and fixed (see below).

## Linters gaining auto-correction

| Linter | Before | After |
| --- | --- | --- |
| **UnnecessaryStringOutput** | `%tag= "Some #{x}"` | `%tag Some #{x}` |
| **HtmlAttributes** | `%tag(href="x" data=foo)` | `%tag{ "href" => "x",
"data" => foo }` |
| **ConsecutiveSilentScripts** | consecutive `- a` / `- b` / `- c` | a
single `:ruby` filter block |
| **AlignmentTabs** | `%p⇥Hello` | `%p Hello` |

### Safety notes per linter

- **UnnecessaryStringOutput** — rebuilds the plain text from the parsed
string literal, keeping `#{...}` interpolation and escaping literal `#{`
so Haml won't interpolate it. Keeps the existing equivalence guards
(escape sequences, significant whitespace, reserved leading characters)
and leaves `!=`/`~` markers alone.
- **HtmlAttributes** — builds the hash from Haml's already-validated
parse output. Skips (still reports) cases that can't be converted
losslessly: an existing `{...}` group, the `.class`/`#id` shorthand, or
a multiline attribute list. Adds `TagNode#static_attributes` to expose
the parsed static attributes.
- **ConsecutiveSilentScripts** — merges a run into an equivalent `:ruby`
filter, preserving indentation and variable scope. Only merges
single-line scripts on contiguous lines.
- **AlignmentTabs** — collapses each run of alignment tabs into one
space, leaving indentation tabs untouched.

## Bug fixes included

- **`AlignmentTabs` was never running.** It was missing its
`LinterRegistry` registration, so it was never selected during real runs
despite being `enabled: true` in the default ... (continued)

104 of 105 new or added lines in 5 files covered. (99.05%)

3150 of 3231 relevant lines covered (97.49%)

23031.17 hits per line