kubeflow / trainer / 29267477551

68%

push

github

feat: implement runtime snapshot mechanism (KEP-2599) (#3580)

* test: add failing e2e test

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rob Bell <robell@redhat.com>

* feat: add snapshot implementation

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rob Bell <robell@redhat.com>

* test: add unit tests for snapshot utils

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rob Bell <robell@redhat.com>

* test: add integration tests for snapshots

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rob Bell <robell@redhat.com>

* docs: update KEP-2170 to reflect snapshot-based runtime approach

Replace runtime immutability/versioning with snapshot mechanism.
References KEP-2599 for implementation details.

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rob Bell <robell@redhat.com>

* chore: run go mod tidy

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: address Copilot review comments on runtime snapshots

- Fix nil pointer dereference by validating Kind/APIGroup before
  dereferencing. When nil, accept any value in snapshot validation.
- Fix spelling: "unmarshall" -> "unmarshal" in error message and test

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rob Bell <robell@redhat.com>

* fix: update tests and docs from review feedback

Signed-off-by: Rob Bell <robell@redhat.com>

* fix: check snapshot configmap owner

Signed-off-by: Rob Bell <robell@redhat.com>

---------

Signed-off-by: Rob Bell <robell@redhat.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

79 of 91 new or added lines in 3 files covered. (86.81%)

2510 of 3748 relevant lines covered (66.97%)

0.78 hits per line